-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projection expressions #5040
Projection expressions #5040
Conversation
interpolate-projection
)
interpolate-projection
)interpolate-projection
etc.)
interpolate-projection
etc.)interpolate-projection
, step
)
src/ui/events.ts
Outdated
@@ -752,7 +752,7 @@ export type MapProjectionEvent = { | |||
* Specifies the name of the new projection. | |||
* Additionally includes 'globe-mercator' to describe globe that has internally switched to mercator. | |||
*/ | |||
newProjection: ProjectionSpecification['type'] | 'globe-mercator'; | |||
newProjection: ProjectionConfigSpecification['type'] | 'globe-mercator'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove globe-mercator
?
I was expecting the code here to use the expression value of projection, is it using the expression value somewhere that I have missed? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5040 +/- ##
==========================================
+ Coverage 89.25% 89.27% +0.02%
==========================================
Files 269 269
Lines 38286 38330 +44
Branches 2347 2427 +80
==========================================
+ Hits 34172 34220 +48
- Misses 3117 3130 +13
+ Partials 997 980 -17 ☔ View full report in Codecov by Sentry. |
interpolate-projection
, step
)a41bc49
to
d207641
Compare
@HarelM , there is some preparation work needed in GL JS before this can be hooked up to the map style. I think the best take on it is to make this PR just an "'update style-spec", allowing the createExpression to work. Then we can refactor incrementally on the main branch, until we can hook it up to the map.style, and only then make the changelog item for the new feature. Do you think that can work? For example, I see some issues with tile loading, when going between projections: Screen.Recording.2024-11-17.at.14.38.39.movAnd if terrain is enabled, the globe/vertical-perspective fog appear to break things. Screen.Recording.2024-11-17.at.14.39.52.movAlso, the vertical-perspective projection, in the setProjection, it doesn't take a globeness value that we can use to pass in the Also there could be some perf here, where we maybe should update the globeness in the existing projection instance, instead of making a lot of new Projection instances. |
Spec package will be updated automatically in a few days by dependabot. |
Sounds good, I'll leave it to dependabot to make the version change (thought it didn't handled major-release updates). |
Blocked by / How to use
Closes #5039
interpolate
exampleScreen.Recording.2024-11-13.at.01.28.44.mov
step
exampleScreen.Recording.2024-11-13.at.01.50.51.mov
Launch Checklist
CHANGELOG.md
under the## main
section.